P2X-1023 exclude inline assests from PRL #9194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmark ResultsKitchen Sink ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
|
AGawrys
requested changes
Aug 15, 2023
packages/core/integration-tests/test/integration/inlined-assests/bar.js
Outdated
Show resolved
Hide resolved
packages/core/integration-tests/test/integration/inlined-assests/c.js
Outdated
Show resolved
Hide resolved
AGawrys
approved these changes
Aug 17, 2023
irismoini
force-pushed
the
imoini/P2X-1023-exclude-inline-assests-from-PRL
branch
from
97fc88b
to
fdc3a4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Currently, inline assets are counted towards Parcel's Parallel Request Limit (PRL) when they shouldn't be. This PR filters out inline assets in the PRL count.
💻 Examples
For example, if the PRL is set to two and there is one individual bundle, one shared bundle, and one inline asset (three bundles total) in a single bundle group, the shared bundle should not be removed in order to meet the PRL. This is because the inline asset should not count toward the PRL to begin with.
In the above example, bundle group one contains nodes 1, 2 & 4. The PRL is set to two. Because the inline bundle doesn't count toward the PRL the shared bundle (node 4) is not removed in order the met the PRL and the bundle graph pre-check against the PRL and post check remains the same.
🚨 Test instructions
NA
✔️ PR Todo