Merge all native Rust modules into one package #9146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcins
approved these changes
Jul 31, 2023
crates/node-bindings/Cargo.toml
Outdated
|
|
||
| [target.'cfg(not(target_arch = "wasm32"))'.dependencies] | ||
| parcel-dev-dep-resolver = { path = "../../packages/utils/dev-dep-resolver" } | ||
| oxipng = "6.0.0" |
There was a problem hiding this comment.
I recently bumped oxipng to 8.0.0 to resolve a compilation issue on one of the architectures - have you rebased recently on the latest v2 changes?
# Conflicts: # packages/core/core/src/Parcel.js # packages/core/core/src/requests/AssetGraphRequest.js # packages/packagers/js/src/index.js
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges all of our native Rust modules into a single package,
@parcel/rust(name TBD). Rather than publishing separate packages to npm, each with a separate binary (per platform), this will combine all of them together into one binary. That way the binary size should be reduced due to avoiding duplicate Rust crates, and we can simplify our publishing step once we start publishing each platform as its own package to reduce install size. It will also enable future things such as sharing a Rust thread pool between different modules.For WASM this also unifies all of our packages around
napi-wasm, which means we don't need a separate wasm-bindgen backend.To do