Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This fixes an issue building for
aarch64-unknown-linux-musl
(e.g.: https://github.com/parcel-bundler/parcel/actions/runs/5433723752/jobs/9881567018) - where a C dependency ofoxipng
(cloudflare-zlib-sys
) was failing to compile. The latest version does not use this dependency.🚨 Test instructions
If the integration tests still work, this should be okay.. the code change was only to remove a default.
I validated that
yarn build-release --target aarch64-unknown-linux-musl
in the image optimizer now works in the same Docker container as CI uses after applying this change, where previously it was failing.✔️ PR Todo