Web extension patches #9068
Merged
Web extension patches #9068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @devongovett |
|
Bump - this should be relatively safe to merge, I've been using a |
Benchmark ResultsKitchen Sink ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
mischnic
reviewed
Sep 14, 2023
| }, | ||
| { | ||
| filePath: __filename, | ||
| // cache bust on non-asset manifest.json changes |
There was a problem hiding this comment.
Why exactly are all of these caching workaround necessary here (this and invalidateOnBuild above)?
There was a problem hiding this comment.
This seems to be the only way to make the extension reload (i.e. have an HMR update sent out) when the manifest.json changes. I tried many other strategies but none seemed to work.
mischnic
reviewed
Sep 14, 2023
devongovett
approved these changes
Oct 3, 2023
mischnic
approved these changes
Oct 3, 2023
|
And once again: thank you for your contributions for the web extension functionality! |
|
Thank you @101arrowz! |
lukaw3d
reviewed
Nov 3, 2023
| program.permissions.push('scripting'); | ||
| } | ||
| const hostPerms = [ | ||
| ...new Set(program.content_scripts.flatMap(sc => sc.matches)), |
There was a problem hiding this comment.
I'm getting an error here: @parcel/transformer-webextension: Cannot read properties of undefined (reading 'flatMap')
Trying to build a MV2 without content_scripts
|
Are these changes already available in Parcel 2.10.2? If not, is it foreseeable when they are going to be released? Thanks! |
|
Yes, this was released as part of 2.10.0 |
The issue described in #8785 appears to still be happening for me using v2.10.3. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
Fixes #8159
Fixes #8404
Fixes #8590
Fixes #8707
Fixes #8785
Closes #8906
This PR should generally fix some of the key issues with the web extension transformer. The main key issue remaining is #8071; the rest of the open issues are mostly QoL things. This PR might fix also #8071 but I can't test it extensively enough to verify.
This PR also makes two key changes to how HMR works. Now, extension reloads cause all active content scripts to reload as well, and content scripts wait 500ms to give time for the extension to reload before they reload their own webpages.
Not sure how testable these changes are, but there are some questionable modifications I made in
hmr-runtime.jsthat may be worth looking at closely.