Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't send HMR updates before packaging in watch mode #9026

Merged
merged 2 commits into from
May 22, 2023

Conversation

mischnic
Copy link
Member

Since #8582, HMR updates are sent before bundles are written to disk because the dev server stalls any potential requests until the build is finished (and it never serves outdated bundles from the previous build).

But when not using the builtin dev server, outdated bundles will be served (non-deterministically depending on how quickly the browser triggers the page reload and how long Parcel takes to write all bundles).

Now, the optimization from that PR is only used when the builtin dev server is used (so not for parcel watch). I don't think there's anything else we can here

Closes #8940

@mischnic mischnic requested a review from devongovett May 18, 2023 21:25
@mischnic mischnic merged commit ca244bb into v2 May 22, 2023
@mischnic mischnic deleted the watch-mode-hmr-before-package branch May 22, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hot reload refreshes before updating (shows pervious version)
2 participants