Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EntryResolver.resolveEntry infinite loop when entries look like globs #9020

Merged
merged 6 commits into from
Jun 3, 2023

Conversation

hacknlove
Copy link
Contributor

@hacknlove hacknlove commented May 16, 2023

↪️ Pull Request

#8519

💻 Examples

if you try to build any file whose path looks like a glob, like /blog/[id].html it will cause a infinite loop

🚨 Test instructions

✔️ PR Todo

I wasn't able to run test locally, I am having this error:

/parcel/packages/core/core/src/AssetGraph.js: Cannot find module '@parcel/hash'

Even with v2 branch.

I couldn't find any solution. Maybe I need some guidance.

Also with the linter, It was erroring, but it was not showing any specific reason.

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@mischnic
Copy link
Member

mischnic commented May 16, 2023

Cannot find module '@parcel/hash'

You need to have Rust installed and then run yarn build-native in the monorepo root.

@hacknlove
Copy link
Contributor Author

hacknlove commented May 18, 2023

I like better this last commit. I think it's simpler and faster, because it requires less stat checks operations.

But the previous one will do the job too.

@joshamaju
Copy link

joshamaju commented May 25, 2023

Any chance on reviewing and merging this?

Copy link
Member

@mischnic mischnic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mischnic mischnic merged commit 0645f64 into parcel-bundler:v2 Jun 3, 2023
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants