Fix multiple entries pointing to wrong bundle in dist #8991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devongovett
reviewed
May 12, 2023
| @@ -347,6 +347,10 @@ function getLoaderRuntime({ | |||
| } | |||
|
|
|||
| let externalBundles = bundleGraph.getBundlesInBundleGroup(bundleGroup); | |||
| externalBundles = externalBundles.filter( | |||
| externalBundle => externalBundle.target == bundle.target, | |||
| ); | |||
There was a problem hiding this comment.
One question is how bundles from multiple different targets are getting into the same bundle groups in the first place?
There was a problem hiding this comment.
I believe I fixed it properly now 😅 @devongovett , added an updated graph pic as well where theres two separate bundlegroups for each target :)
Only issue here could be if targets don't have a name but I thought they would always have one? Is that true?
AGawrys
force-pushed
the
entries-bug-050423
branch
from
548e911
to
0c8782c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
↪️ Pull Request
This aims to fix issue #8864 , Where specifying two dists, with an external shared bundle caused the wrong relative path to be placed in the loader code. I don't think this is an issue with the bundler algorithm though, since it still created separate shared bundles for each dist and the edges were fine. (see graph below)
Anyway, so it looks like the wrong path occurs when gettingexternalBundlesin the runtime code. It grabs both shared bundles (for each target) and then picked the first match by asset, which didn't take into account targets. Not sure if this fix is best, so do let me know.Update: I've added the target name when keying for bundlegroups, which actually addresses the problem of having two identical bundles (same entry asset) under the same bundlegroup.
💻 Examples
BEFORE:
AFTER:
🚨 Test instructions
Test case and @joeyslater 's reproduction
✔️ PR Todo