Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "does not exports" error for multiple assets returned by transformers #8947

Merged
merged 2 commits into from
Apr 28, 2023

Conversation

mischnic
Copy link
Member

Previously, this would have caused

🚨 Build failed.
Error: false == true

  AssertionError [ERR_ASSERTION]: false == true
      at visit (parcel/packages/core/core/src/SymbolPropagation.js:430:13)
      at walk (parcel/packages/core/core/src/SymbolPropagation.js:676:19)
      at walk (parcel/packages/core/core/src/SymbolPropagation.js:651:11)
      at walk (parcel/packages/core/core/src/SymbolPropagation.js:651:11)
      at walk (parcel/packages/core/core/src/SymbolPropagation.js:651:11)
      at walk (parcel/packages/core/core/src/SymbolPropagation.js:651:11)
      at walk (parcel/packages/core/core/src/SymbolPropagation.js:651:11)
      at walk (parcel/packages/core/core/src/SymbolPropagation.js:651:11)
      at walk (parcel/packages/core/core/src/SymbolPropagation.js:651:11)
      at walk (parcel/packages/core/core/src/SymbolPropagation.js:651:11)

because the situation of Dependency -> Asset instead of Dependency -> AssetGroup -> Asset doesn't happen with the usual plugins.

@mischnic mischnic changed the title Fix "does not exports" error for multi-assets Fix "does not exports" error for multiple assets returned by transformers Apr 17, 2023
@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.91s -18.00ms
Cached 451.00ms +14.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/legacy/index.7d75205b.js 1.63kb +0.00b 487.00ms -29.00ms 🚀
dist/legacy/index.d20f91ee.js 1.19kb +0.00b 489.00ms -25.00ms 🚀
dist/modern/index.1ee30fe4.js 1.12kb +0.00b 486.00ms -31.00ms 🚀
dist/legacy/index.html 826.00b +0.00b 531.00ms -82.00ms 🚀
dist/modern/index.html 749.00b +0.00b 529.00ms -80.00ms 🚀

Cached Bundles

No bundle changes detected.

React HackerNews ✅

Timings

Description Time Difference
Cold 8.11s -266.00ms
Cached 576.00ms +36.00ms ⚠️

Cold Bundles

Bundle Size Difference Time Difference
dist/PermalinkedComment.60e78a07.js 4.18kb +0.00b 529.00ms -48.00ms 🚀
dist/UserProfile.c18819ee.js 1.57kb +0.00b 529.00ms -49.00ms 🚀
dist/NotFound.cfeedbab.js 427.00b +0.00b 528.00ms -49.00ms 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/index.js 463.02kb +0.00b 1.34s +144.00ms ⚠️
dist/PermalinkedComment.60e78a07.js 4.18kb +0.00b 617.00ms +69.00ms ⚠️
dist/UserProfile.c18819ee.js 1.57kb +0.00b 617.00ms +69.00ms ⚠️
dist/NotFound.cfeedbab.js 427.00b +0.00b 616.00ms +68.00ms ⚠️

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.27m +176.00ms
Cached 2.56s -142.00ms 🚀

Cold Bundles

Bundle Size Difference Time Difference
dist/pdfRenderer.4f3765de.js 1.11mb +0.00b 15.68s -812.00ms 🚀
dist/component-lazy.60375b05.js 60.45kb +0.00b 8.14s +1.07s ⚠️
dist/component.e578d640.js 58.27kb +0.00b 7.07s +357.00ms ⚠️
dist/mobile-upload.93995326.js 8.08kb +0.00b 7.06s +353.00ms ⚠️
dist/Modal.4d03aeec.js 3.79kb +0.00b 7.06s +353.00ms ⚠️
dist/16.dd50aef4.js 1.41kb +0.00b 7.07s +356.00ms ⚠️
dist/16.8d078bd1.js 1.08kb +0.00b 7.07s +357.00ms ⚠️
dist/16.bb53313d.js 1.08kb +0.00b 7.07s +356.00ms ⚠️
dist/16.99296be0.js 964.00b +0.00b 7.09s +371.00ms ⚠️
dist/simpleHasher.395b29e6.js 687.00b +0.00b 7.05s +353.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/index.9f855f80.js 3.83mb +0.00b 20.81s +1.11s ⚠️
dist/pdfRenderer.4f3765de.js 1.11mb +0.00b 15.74s +1.06s ⚠️
dist/editorView.19055bae.js 622.48kb +0.00b 16.64s +995.00ms ⚠️
dist/refractor.c460668c.js 601.81kb +0.00b 14.41s +872.00ms ⚠️
dist/media-viewer.bd165005.js 542.15kb +0.00b 14.37s +994.00ms ⚠️
dist/popup.8679a203.js 329.78kb +0.00b 14.41s +884.00ms ⚠️
dist/ConfigPanelFieldsLoader.f06a6b36.js 312.08kb +0.00b 10.39s +566.00ms ⚠️
dist/EmojiPickerComponent.a25bd8e7.js 196.67kb +0.00b 14.40s +1.03s ⚠️
dist/card.501ecffa.js 143.52kb +0.00b 10.38s +567.00ms ⚠️
dist/ConfigPanelFieldsLoader.e1ae433f.js 83.45kb +0.00b 10.38s +566.00ms ⚠️
dist/mobile-upload.f055fc7f.js 66.66kb +0.00b 6.85s +573.00ms ⚠️
dist/ElementBrowser.3bcad544.js 65.85kb +0.00b 10.38s +567.00ms ⚠️
dist/esm.6df2a542.js 64.51kb +0.00b 14.41s +885.00ms ⚠️
dist/archive.b919f1ad.js 61.47kb +0.00b 14.41s +873.00ms ⚠️
dist/esm.945b66be.js 60.94kb +0.00b 10.38s +567.00ms ⚠️
dist/component-lazy.60375b05.js 60.45kb +0.00b 7.22s +539.00ms ⚠️
dist/component.e578d640.js 58.27kb +0.00b 6.86s +575.00ms ⚠️
dist/DatePicker.3a60f244.js 48.38kb +0.00b 7.95s +488.00ms ⚠️
dist/esm.bd488cd8.js 40.24kb +0.00b 14.41s +874.00ms ⚠️
dist/Modal.4be3b837.js 28.46kb +0.00b 6.83s +564.00ms ⚠️
dist/DatePicker.b0a4d8f4.js 25.21kb +0.00b 7.95s +488.00ms ⚠️
dist/smartMediaEditor.8713e5a6.js 22.24kb +0.00b 14.41s +873.00ms ⚠️
dist/esm.a10f92b5.js 21.06kb +0.00b 14.41s +873.00ms ⚠️
dist/component.1c22aee9.js 18.81kb +0.00b 6.84s +556.00ms ⚠️
dist/js.324be058.js 17.34kb +0.00b 6.83s +563.00ms ⚠️
dist/ConfigPanelFieldsLoader.ef739802.js 16.14kb +0.00b 10.38s +565.00ms ⚠️
dist/ui.2de0ef21.js 14.88kb +0.00b 10.38s +566.00ms ⚠️
dist/ConfigPanelFieldsLoader.c68d84ab.js 14.25kb +0.00b 10.38s +565.00ms ⚠️
dist/dropzone.4b8113c9.js 14.00kb +0.00b 14.41s +873.00ms ⚠️
dist/pdfRenderer.187ba54d.js 12.21kb +0.00b 10.38s +566.00ms ⚠️
dist/dropzone.ae8c8d79.js 11.95kb +0.00b 14.41s +873.00ms ⚠️
dist/Toolbar.7fda8a1b.js 9.30kb +0.00b 14.41s +874.00ms ⚠️
dist/clipboard.ef3ddc39.js 8.22kb +0.00b 14.41s +873.00ms ⚠️
dist/mobile-upload.93995326.js 8.08kb +0.00b 6.83s +564.00ms ⚠️
dist/mobile-upload.136dd5cb.js 8.08kb +0.00b 10.38s +566.00ms ⚠️
dist/mobile-upload.0bdb676c.js 8.08kb +0.00b 10.39s +567.00ms ⚠️
dist/mobile-upload.31f0e326.js 8.08kb +0.00b 14.41s +873.00ms ⚠️
dist/browser.0a7fd453.js 7.48kb +0.00b 14.41s +884.00ms ⚠️
dist/index.b2eab848.js 7.32kb +0.00b 14.41s +873.00ms ⚠️
dist/index.b16227d6.css 4.08kb +0.00b 14.43s +875.00ms ⚠️
dist/Modal.4d03aeec.js 3.79kb +0.00b 6.83s +564.00ms ⚠️
dist/media-viewer-analytics-error-boundary.e6109a6a.js 3.46kb +0.00b 14.41s +873.00ms ⚠️
dist/media-picker-analytics-error-boundary.627962a5.js 3.46kb +0.00b 14.41s +874.00ms ⚠️
dist/media-card-analytics-error-boundary.ec5ff8ee.js 3.45kb +0.00b 14.41s +872.00ms ⚠️
dist/component.9a535981.js 3.42kb +0.00b 6.83s +563.00ms ⚠️
dist/png-chunks-extract.c54842d7.js 3.19kb +0.00b 6.83s +565.00ms ⚠️
dist/ru.896915b9.js 2.94kb +0.00b 10.38s +567.00ms ⚠️
dist/uk.48c97550.js 2.89kb +0.00b 10.38s +565.00ms ⚠️
dist/codeViewerRenderer.915ef6b3.js 2.84kb +0.00b 10.38s +566.00ms ⚠️
dist/th.31044730.js 2.73kb +0.00b 10.38s +565.00ms ⚠️
dist/ResourcedEmojiComponent.04d67e5e.js 2.69kb +0.00b 7.95s +487.00ms ⚠️
dist/pl.5f36d63e.js 2.38kb +0.00b 7.95s +488.00ms ⚠️
dist/cs.971d1d60.js 2.36kb +0.00b 7.95s +487.00ms ⚠️
dist/de.6efbb375.js 2.30kb +0.00b 7.95s +487.00ms ⚠️
dist/fr.af2c92ae.js 2.25kb +0.00b 7.95s +488.00ms ⚠️
dist/es.23f0c164.js 2.25kb +0.00b 7.95s +487.00ms ⚠️
dist/hu.8323f36b.js 2.23kb +0.00b 7.95s +488.00ms ⚠️
dist/fi.7ed4b1b5.js 2.22kb +0.00b 7.95s +486.00ms ⚠️
dist/ja.5653161c.js 2.22kb +0.00b 7.95s +488.00ms ⚠️
dist/vi.d8dcb67a.js 2.22kb +0.00b 10.38s +566.00ms ⚠️
dist/pt_BR.eccfad73.js 2.19kb +0.00b 7.95s +488.00ms ⚠️
dist/tr.46f26598.js 2.16kb +0.00b 10.38s +565.00ms ⚠️
dist/ko.2cf2bbda.js 2.11kb +0.00b 7.95s +488.00ms ⚠️
dist/sv.13d93533.js 2.10kb +0.00b 10.38s +566.00ms ⚠️
dist/it.601d375a.js 2.10kb +0.00b 7.95s +488.00ms ⚠️
dist/nb.b300dd3e.js 2.09kb +0.00b 7.95s +488.00ms ⚠️
dist/date.7b2f9581.js 2.07kb +0.00b 7.22s +538.00ms ⚠️
dist/da.21385cf2.js 2.07kb +0.00b 7.95s +486.00ms ⚠️
dist/nl.3999ea58.js 2.07kb +0.00b 7.95s +488.00ms ⚠️
dist/images.46c877f3.js 2.03kb +0.00b 7.22s +538.00ms ⚠️
dist/zh_TW.afaf6222.js 1.98kb +0.00b 10.38s +566.00ms ⚠️
dist/zh.fcdc32bb.js 1.96kb +0.00b 10.38s +566.00ms ⚠️
dist/feedback.fd1f6260.js 1.89kb +0.00b 7.95s +487.00ms ⚠️
dist/status.6f638b3d.js 1.80kb +0.00b 7.22s +536.00ms ⚠️
dist/workerHasher.be59eb41.js 1.72kb +0.00b 6.83s +563.00ms ⚠️
dist/workerHasher.ef49a7fc.js 1.72kb +0.00b 10.38s +567.00ms ⚠️
dist/workerHasher.9d5fe27b.js 1.72kb +0.00b 10.39s +567.00ms ⚠️
dist/workerHasher.13de9709.js 1.72kb +0.00b 14.41s +885.00ms ⚠️
dist/workerHasher.99c37306.js 1.72kb +0.00b 14.41s +873.00ms ⚠️
dist/workerHasher.c5ba46bc.js 1.72kb +0.00b 14.41s +873.00ms ⚠️
dist/code.ef3dfa9c.js 1.69kb +0.00b 7.22s +538.00ms ⚠️
dist/list-number.35bc7f17.js 1.60kb +0.00b 7.22s +538.00ms ⚠️
dist/heading6.974f167d.js 1.49kb +0.00b 7.95s +488.00ms ⚠️
dist/16.87c743d1.js 1.48kb +0.00b 6.86s +573.00ms ⚠️
dist/heading3.9ad47cbe.js 1.48kb +0.00b 7.22s +537.00ms ⚠️
dist/16.dd50aef4.js 1.41kb +0.00b 6.85s +574.00ms ⚠️
dist/link.542e87bf.js 1.41kb +0.00b 7.22s +539.00ms ⚠️
dist/emoji.79757e2c.js 1.38kb +0.00b 7.22s +538.00ms ⚠️
dist/heading5.023a8f1f.js 1.36kb +0.00b 7.95s +488.00ms ⚠️
dist/expand.801fc3a0.js 1.31kb +0.00b 7.95s +487.00ms ⚠️
dist/heading2.bffcdf12.js 1.30kb +0.00b 7.22s +538.00ms ⚠️
dist/heading4.05995ed9.js 1.25kb +0.00b 7.22s +519.00ms ⚠️
dist/mention.adafe481.js 1.21kb +0.00b 7.22s +537.00ms ⚠️
dist/layout.40f6b132.js 1.17kb +0.00b 7.22s +538.00ms ⚠️
dist/divider.616b37d8.js 1.17kb +0.00b 7.22s +538.00ms ⚠️
dist/action.361730a6.js 1.15kb +0.00b 7.22s +538.00ms ⚠️
dist/heading1.495af5dc.js 1.14kb +0.00b 7.22s +538.00ms ⚠️
dist/16.9e7cc0d9.js 1.13kb +0.00b 6.86s +575.00ms ⚠️
dist/list.c5ad55b6.js 1.11kb +0.00b 7.22s +538.00ms ⚠️
dist/quote.235ab420.js 1.11kb +0.00b 7.22s +537.00ms ⚠️
dist/decision.36a0b771.js 1.10kb +0.00b 7.22s +538.00ms ⚠️
dist/16.8d078bd1.js 1.08kb +0.00b 6.85s +574.00ms ⚠️
dist/16.bb53313d.js 1.08kb +0.00b 6.86s +574.00ms ⚠️
dist/panel-warning.7e72ad42.js 1.07kb +0.00b 7.22s +537.00ms ⚠️
dist/16.88e24f19.js 1.06kb +0.00b 6.83s +564.00ms ⚠️
dist/16.0d8c3c9e.js 1.06kb +0.00b 7.21s +538.00ms ⚠️
dist/table.389f0908.js 1.05kb +0.00b 7.22s +537.00ms ⚠️
dist/16.db9c75f1.js 1.03kb +0.00b 6.87s +569.00ms ⚠️
dist/panel.7cee1972.js 1017.00b +0.00b 7.22s +537.00ms ⚠️
dist/panel-error.e46252ff.js 994.00b +0.00b 7.22s +537.00ms ⚠️
dist/16.c0880b62.js 992.00b +0.00b 6.86s +573.00ms ⚠️
dist/16.99296be0.js 964.00b +0.00b 6.87s +567.00ms ⚠️
dist/16.c16ee42d.js 957.00b +0.00b 6.84s +558.00ms ⚠️
dist/16.dcf139e7.js 951.00b +0.00b 7.22s +539.00ms ⚠️
dist/panel-success.dbd2515b.js 935.00b +0.00b 7.22s +537.00ms ⚠️
dist/panel-note.b6c94ff5.js 925.00b +0.00b 7.22s +538.00ms ⚠️
dist/16.26c3d518.js 912.00b +0.00b 6.85s +572.00ms ⚠️
dist/16.f76b9cae.js 906.00b +0.00b 6.85s +573.00ms ⚠️
dist/16.fb327623.js 906.00b +0.00b 6.86s +575.00ms ⚠️
dist/16.f2056258.js 905.00b +0.00b 6.86s +574.00ms ⚠️
dist/16.4e7dec68.js 904.00b +0.00b 6.84s +558.00ms ⚠️
dist/16.400116d9.js 903.00b +0.00b 6.84s +558.00ms ⚠️
dist/16.f6395317.js 876.00b +0.00b 7.22s +539.00ms ⚠️
dist/16.24326b68.js 855.00b +0.00b 6.84s +558.00ms ⚠️
dist/16.0285f4b2.js 827.00b +0.00b 6.86s +549.00ms ⚠️
dist/sk.101f1705.js 786.00b +0.00b 10.38s +567.00ms ⚠️
dist/pt_PT.402f9c4e.js 765.00b +0.00b 7.95s +487.00ms ⚠️
dist/et.69382942.js 763.00b +0.00b 7.95s +487.00ms ⚠️
dist/simpleHasher.395b29e6.js 687.00b +0.00b 6.83s +564.00ms ⚠️
dist/simpleHasher.f1f58b0a.js 687.00b +0.00b 10.38s +566.00ms ⚠️
dist/simpleHasher.09f4d713.js 687.00b +0.00b 10.39s +567.00ms ⚠️
dist/simpleHasher.a19114f9.js 687.00b +0.00b 14.41s +885.00ms ⚠️
dist/simpleHasher.023b58fa.js 687.00b +0.00b 14.41s +873.00ms ⚠️
dist/simpleHasher.97222d8a.js 687.00b +0.00b 14.41s +873.00ms ⚠️
dist/is.5b945719.js 625.00b +0.00b 7.95s +488.00ms ⚠️
dist/ro.a6eff34a.js 612.00b +0.00b 7.95s +488.00ms ⚠️
dist/en_GB.61f7112a.js 602.00b +0.00b 7.95s +487.00ms ⚠️
dist/en.41261459.js 599.00b +0.00b 7.95s +486.00ms ⚠️
dist/index.html 240.00b +0.00b 14.52s +891.00ms ⚠️

Three.js ✅

Timings

Description Time Difference
Cold 5.84s -37.00ms
Cached 335.00ms -73.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

Bundle Size Difference Time Difference
dist/Three.js 572.22kb +0.00b 1.28s +123.00ms ⚠️

Click here to view a detailed benchmark overview.

@mischnic mischnic merged commit 4f45fa1 into v2 Apr 28, 2023
@mischnic mischnic deleted the multi-asset-does-not-export branch April 28, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants