Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix css-module related build error in bundling #8885

Merged
merged 6 commits into from
Mar 26, 2023
Merged

Fix css-module related build error in bundling #8885

merged 6 commits into from
Mar 26, 2023

Conversation

AGawrys
Copy link
Contributor

@AGawrys AGawrys commented Mar 14, 2023

↪️ Pull Request

This addresses issue #8716, where twocss-modules siblings merging, had orphaned a node in the graph. To fix this, we must add in those orphans and re-map our asset-to-bundles, bundleRoots, structure to allow for more than one asset pointing to the same bundle.

💻 Examples

See issue

🚨 Test instructions

To fix reproduction, update Parcel to latest & add this fix. ✅

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

@parcel-benchmark
Copy link

parcel-benchmark commented Mar 14, 2023 •
edited
Loading

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.79s +4.00ms
Cached 393.00ms +2.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

React HackerNews ✅

Timings

Description Time Difference
Cold 8.34s -37.00ms
Cached 505.00ms +12.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/PermalinkedComment.60e78a07.js 4.18kb +0.00b 538.00ms -32.00ms 🚀
dist/UserProfile.c18819ee.js 1.57kb +0.00b 539.00ms -31.00ms 🚀
dist/NotFound.cfeedbab.js 427.00b +0.00b 539.00ms -30.00ms 🚀
dist/logo.c5bb83f1.png 246.00b +0.00b 433.00ms +48.00ms ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/PermalinkedComment.60e78a07.js 4.18kb +0.00b 553.00ms +33.00ms ⚠️
dist/UserProfile.c18819ee.js 1.57kb +0.00b 553.00ms +33.00ms ⚠️
dist/NotFound.cfeedbab.js 427.00b +0.00b 553.00ms +34.00ms ⚠️
dist/logo.c5bb83f1.png 246.00b +0.00b 407.00ms +29.00ms ⚠️

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.22m -1.72s
Cached 2.56s -41.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/media-viewer.bd165005.js 542.15kb +0.00b 12.75s +3.08s ⚠️
dist/archive.503fa405.js 61.48kb +0.00b 12.74s +3.07s ⚠️
dist/component-lazy.60375b05.js 60.45kb +0.00b 6.44s -808.00ms 🚀
dist/media-viewer-analytics-error-boundary.e6109a6a.js 3.46kb +0.00b 12.75s +3.08s ⚠️
dist/ru.896915b9.js 2.94kb +0.00b 9.25s +1.99s ⚠️
dist/heading5.023a8f1f.js 1.36kb +0.00b 7.15s +658.00ms ⚠️
dist/index.html 240.00b +0.00b 12.83s +6.78s ⚠️

Cached Bundles

Bundle Size Difference Time Difference
dist/EmojiPickerComponent.a25bd8e7.js 196.67kb +0.00b 9.25s -3.96s 🚀
dist/component-lazy.60375b05.js 60.45kb +0.00b 6.39s -858.00ms 🚀
dist/codeViewerRenderer.915ef6b3.js 2.84kb +0.00b 9.25s -3.96s 🚀
dist/ro.a6eff34a.js 612.00b +0.00b 7.04s -2.65s 🚀

Three.js ✅

Timings

Description Time Difference
Cold 5.79s +92.00ms
Cached 326.00ms +4.00ms

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@parcel-benchmark
Copy link

Benchmark Results

Kitchen Sink ✅

Timings

Description Time Difference
Cold 1.51s +17.00ms
Cached 368.00ms +34.00ms ⚠️

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

React HackerNews ✅

Timings

Description Time Difference
Cold 7.05s +75.00ms
Cached 427.00ms -34.00ms 🚀

Cold Bundles

No bundle changes detected.

Cached Bundles

No bundle changes detected.

AtlasKit Editor ✅

Timings

Description Time Difference
Cold 1.07m -437.00ms
Cached 2.22s -35.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/index.0976f9cb.js 3.83mb +0.00b 17.14s -1.26s 🚀
dist/pdfRenderer.4f3765de.js 1.11mb +0.00b 12.62s -922.00ms 🚀
dist/refractor.c460668c.js 601.81kb +0.00b 11.09s -726.00ms 🚀
dist/media-viewer.bd165005.js 542.15kb +0.00b 8.29s -3.52s 🚀
dist/popup.2cbde099.js 329.78kb +0.00b 11.09s -728.00ms 🚀
dist/EmojiPickerComponent.a25bd8e7.js 196.67kb +0.00b 8.30s -3.52s 🚀
dist/esm.6df2a542.js 64.51kb +0.00b 11.09s -728.00ms 🚀
dist/archive.503fa405.js 61.48kb +0.00b 8.29s -3.52s 🚀
dist/DatePicker.3a60f244.js 48.38kb +0.00b 6.06s -407.00ms 🚀
dist/esm.bd488cd8.js 40.24kb +0.00b 11.09s -726.00ms 🚀
dist/Modal.4be3b837.js 28.46kb +0.00b 5.20s -268.00ms 🚀
dist/DatePicker.b0a4d8f4.js 25.21kb +0.00b 6.06s -407.00ms 🚀
dist/smartMediaEditor.8713e5a6.js 22.24kb +0.00b 11.09s -726.00ms 🚀
dist/esm.a10f92b5.js 21.06kb +0.00b 11.09s -726.00ms 🚀
dist/dropzone.4b8113c9.js 14.00kb +0.00b 11.09s -728.00ms 🚀
dist/dropzone.ae8c8d79.js 11.95kb +0.00b 11.09s -727.00ms 🚀
dist/Toolbar.7fda8a1b.js 9.30kb +0.00b 11.09s -726.00ms 🚀
dist/clipboard.ef3ddc39.js 8.22kb +0.00b 11.09s -728.00ms 🚀
dist/mobile-upload.31f0e326.js 8.08kb +0.00b 11.09s -726.00ms 🚀
dist/browser.0a7fd453.js 7.48kb +0.00b 11.09s -728.00ms 🚀
dist/index.6d0e3617.js 7.32kb +0.00b 11.09s -727.00ms 🚀
dist/index.b16227d6.css 4.08kb +0.00b 11.10s -735.00ms 🚀
dist/media-viewer-analytics-error-boundary.e6109a6a.js 3.46kb +0.00b 11.09s -727.00ms 🚀
dist/media-picker-analytics-error-boundary.627962a5.js 3.46kb +0.00b 11.09s -727.00ms 🚀
dist/media-card-analytics-error-boundary.ec5ff8ee.js 3.45kb +0.00b 11.09s -728.00ms 🚀
dist/ResourcedEmojiComponent.04d67e5e.js 2.69kb +0.00b 6.06s -407.00ms 🚀
dist/pl.5f36d63e.js 2.38kb +0.00b 6.07s -407.00ms 🚀
dist/cs.971d1d60.js 2.36kb +0.00b 6.06s -406.00ms 🚀
dist/de.6efbb375.js 2.30kb +0.00b 6.07s -405.00ms 🚀
dist/fr.af2c92ae.js 2.25kb +0.00b 6.07s -405.00ms 🚀
dist/es.23f0c164.js 2.25kb +0.00b 6.07s -405.00ms 🚀
dist/hu.8323f36b.js 2.23kb +0.00b 6.07s -406.00ms 🚀
dist/fi.7ed4b1b5.js 2.22kb +0.00b 6.07s -405.00ms 🚀
dist/ja.5653161c.js 2.22kb +0.00b 6.07s -405.00ms 🚀
dist/pt_BR.eccfad73.js 2.19kb +0.00b 6.07s -407.00ms 🚀
dist/ko.2cf2bbda.js 2.11kb +0.00b 6.07s -405.00ms 🚀
dist/it.601d375a.js 2.10kb +0.00b 6.07s -405.00ms 🚀
dist/nb.b300dd3e.js 2.09kb +0.00b 6.07s -405.00ms 🚀
dist/date.7b2f9581.js 2.07kb +0.00b 5.49s -290.00ms 🚀
dist/da.21385cf2.js 2.07kb +0.00b 6.07s -405.00ms 🚀
dist/nl.3999ea58.js 2.07kb +0.00b 6.07s -406.00ms 🚀
dist/images.46c877f3.js 2.03kb +0.00b 5.49s -290.00ms 🚀
dist/feedback.fd1f6260.js 1.89kb +0.00b 6.06s -407.00ms 🚀
dist/status.6f638b3d.js 1.80kb +0.00b 5.49s -290.00ms 🚀
dist/workerHasher.13de9709.js 1.72kb +0.00b 11.09s -728.00ms 🚀
dist/workerHasher.99c37306.js 1.72kb +0.00b 11.09s -727.00ms 🚀
dist/workerHasher.c5ba46bc.js 1.72kb +0.00b 11.09s -726.00ms 🚀
dist/code.ef3dfa9c.js 1.69kb +0.00b 5.49s -290.00ms 🚀
dist/list-number.35bc7f17.js 1.60kb +0.00b 5.49s -290.00ms 🚀
dist/heading6.974f167d.js 1.49kb +0.00b 6.06s -408.00ms 🚀
dist/16.87c743d1.js 1.48kb +0.00b 5.21s -263.00ms 🚀
dist/heading3.9ad47cbe.js 1.48kb +0.00b 5.49s -292.00ms 🚀
dist/link.542e87bf.js 1.41kb +0.00b 5.49s -290.00ms 🚀
dist/emoji.79757e2c.js 1.38kb +0.00b 5.49s -290.00ms 🚀
dist/heading5.023a8f1f.js 1.36kb +0.00b 6.06s -408.00ms 🚀
dist/expand.801fc3a0.js 1.31kb +0.00b 6.06s -407.00ms 🚀
dist/heading2.bffcdf12.js 1.30kb +0.00b 5.49s -291.00ms 🚀
dist/mention.adafe481.js 1.21kb +0.00b 5.49s -290.00ms 🚀
dist/layout.40f6b132.js 1.17kb +0.00b 5.49s -290.00ms 🚀
dist/divider.616b37d8.js 1.17kb +0.00b 5.49s -290.00ms 🚀
dist/action.361730a6.js 1.15kb +0.00b 5.49s -290.00ms 🚀
dist/heading1.495af5dc.js 1.14kb +0.00b 5.49s -291.00ms 🚀
dist/list.c5ad55b6.js 1.11kb +0.00b 5.49s -290.00ms 🚀
dist/quote.235ab420.js 1.11kb +0.00b 5.49s -290.00ms 🚀
dist/decision.36a0b771.js 1.10kb +0.00b 5.49s -290.00ms 🚀
dist/panel-warning.7e72ad42.js 1.07kb +0.00b 5.49s -290.00ms 🚀
dist/16.88e24f19.js 1.06kb +0.00b 5.20s -268.00ms 🚀
dist/16.0d8c3c9e.js 1.06kb +0.00b 5.49s -290.00ms 🚀
dist/table.389f0908.js 1.05kb +0.00b 5.49s -290.00ms 🚀
dist/16.db9c75f1.js 1.03kb +0.00b 5.22s -269.00ms 🚀
dist/panel.7cee1972.js 1017.00b +0.00b 5.49s -290.00ms 🚀
dist/panel-error.e46252ff.js 994.00b +0.00b 5.49s -290.00ms 🚀
dist/16.99296be0.js 964.00b +0.00b 5.21s -263.00ms 🚀
dist/16.dcf139e7.js 951.00b +0.00b 5.49s -290.00ms 🚀
dist/panel-success.dbd2515b.js 935.00b +0.00b 5.49s -290.00ms 🚀
dist/panel-note.b6c94ff5.js 925.00b +0.00b 5.49s -289.00ms 🚀
dist/16.26c3d518.js 912.00b +0.00b 5.21s -264.00ms 🚀
dist/16.f2056258.js 905.00b +0.00b 5.21s -264.00ms 🚀
dist/16.4e7dec68.js 904.00b +0.00b 5.21s -265.00ms 🚀
dist/16.f6395317.js 876.00b +0.00b 5.49s -289.00ms 🚀
dist/16.0285f4b2.js 827.00b +0.00b 5.22s -268.00ms 🚀
dist/pt_PT.402f9c4e.js 765.00b +0.00b 6.07s -407.00ms 🚀
dist/et.69382942.js 763.00b +0.00b 6.07s -405.00ms 🚀
dist/simpleHasher.a19114f9.js 687.00b +0.00b 11.09s -728.00ms 🚀
dist/simpleHasher.023b58fa.js 687.00b +0.00b 11.09s -727.00ms 🚀
dist/simpleHasher.97222d8a.js 687.00b +0.00b 11.09s -726.00ms 🚀
dist/is.5b945719.js 625.00b +0.00b 6.07s -405.00ms 🚀
dist/ro.a6eff34a.js 612.00b +0.00b 6.07s -407.00ms 🚀
dist/en_GB.61f7112a.js 602.00b +0.00b 6.07s -405.00ms 🚀
dist/en.41261459.js 599.00b +0.00b 6.07s -405.00ms 🚀
dist/index.html 240.00b +0.00b 6.09s -5.79s 🚀

Cached Bundles

Bundle Size Difference Time Difference
dist/media-viewer.bd165005.js 542.15kb +0.00b 8.26s -3.15s 🚀
dist/component-lazy.60375b05.js 60.45kb +0.00b 5.66s -418.00ms 🚀
dist/codeViewerRenderer.915ef6b3.js 2.84kb +0.00b 8.26s -3.17s 🚀
dist/ro.a6eff34a.js 612.00b +0.00b 6.32s -2.05s 🚀

Three.js ✅

Timings

Description Time Difference
Cold 4.92s +163.00ms
Cached 282.00ms +10.00ms

Cold Bundles

Bundle Size Difference Time Difference
dist/Three.js 572.22kb +0.00b 1.03s +59.00ms ⚠️

Cached Bundles

No bundle changes detected.

Click here to view a detailed benchmark overview.

@devongovett devongovett merged commit 9a2bdd9 into v2 Mar 26, 2023
@devongovett devongovett deleted the agawrys/css-module-siblings-orphaned-fix branch March 26, 2023 15:44
@devongovett devongovett mentioned this pull request Mar 26, 2023
Closed
@lukaw3d lukaw3d mentioned this pull request May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

@mattcompiles mattcompiles Awaiting requested review from mattcompiles

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AGawrys @parcel-benchmark @devongovett