-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't run Gzip and Brotli compressors in development #7510
Conversation
|
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached BundlesNo bundle changes detected. React HackerNews ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
AtlasKit Editor ✅
Timings
Cold BundlesNo bundle changes detected. Cached Bundles
Three.js ✅
Timings
Cold BundlesNo bundle changes detected. Cached BundlesNo bundle changes detected. |
Looks like some failing tests? |
Unit tests are still failing on Windows. Maybe something to do with the markdown escaping? |
Allow returning null or undefined from compressors to skip that plugin based on some condition at runtime, and use that to only run the gzip and brotli compressors in production. This is technically a breaking change but I can't image you would want the old behaviour
Other small fixes:
.d.ts
file for @parcel/plugin #7507md
escapes for error messages, closes Slashes and backslashes missing in "file doesn't exist" message #7509