Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix circular bundles, and never hoist the entry asset #548

Merged
merged 1 commit into from
Jan 12, 2018

Conversation

devongovett
Copy link
Member

Slightly simpler, more generic version of #489.

There were two issues:

  1. Infinite recursion on circular bundles. This is solved by tracking the current bundle stack.
  2. HTML files getting merged into one bundle. This was because Parcel tried to hoist the common dependencies. However, this should never be done for the entry asset of a bundle since those assets were explicitly requested to be placed in a separate bundle (deps marked as dynamic).

Added test covers both cases. cc. @shawwn @ipmb

Slightly simpler, more generic version of #489.
@codecov-io
Copy link

codecov-io commented Jan 11, 2018

Codecov Report

Merging #548 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #548      +/-   ##
==========================================
- Coverage   88.36%   88.34%   -0.02%     
==========================================
  Files          56       56              
  Lines        1633     1639       +6     
==========================================
+ Hits         1443     1448       +5     
- Misses        190      191       +1
Impacted Files Coverage Δ
src/Bundler.js 88.88% <100%> (+0.26%) ⬆️
src/utils/installPackage.js 87.5% <0%> (-6.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97cf294...1a7d669. Read the comment docs.

@ipmb
Copy link
Contributor

ipmb commented Jan 11, 2018

works for me!

@devongovett devongovett merged commit dd26db3 into master Jan 12, 2018
@devongovett devongovett deleted the circular-deps branch January 12, 2018 00:30
devongovett added a commit that referenced this pull request Oct 15, 2018
Slightly simpler, more generic version of #489.
devongovett added a commit that referenced this pull request Oct 15, 2018
Slightly simpler, more generic version of #489.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants