-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS SourceMaps #4440
CSS SourceMaps #4440
Conversation
|
ad88371
to
3eee749
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some initial feedback on some things that caught my attention, gonna take a deeper look if tests still fail after fixing these.
(The extensive tests I once added in #2489 still exist in |
3eee749
to
d5cdff8
Compare
d5cdff8
to
51dc23e
Compare
Those use the old |
Benchmark ResultsKitchen Sink ✅
Timings
Cold Bundles
Cached Bundles
React HackerNews ✅
Timings
Cold Bundles
Cached Bundles
AtlasKit Editor ✅
Timings
Cold Bundles
Cached Bundles
Three.js x4 🚨
Timings
Cold BundlesNo bundles found, this is probably a failed build... Cached BundlesNo bundles found, this is probably a failed build... |
@wbinnssmith the new source-map package is fully compatible with the old one, main differences is that it's no longer async and a lot stricter. (ie addMap moved into various different functions addIndexedMappings, addRawMappings, ...) I've updated the tests, they're pretty much all failing somewhere so the maps should be incorrect at the moment. Also updated the typescript sourcemap tests as they were still disabled, shouldn't have any negative impact on this PR |
Just pushed a change that allows for mappings corresponding to the nearest contiguous series of spaces or tabs. I also continued skipping LESS and SASS tests as those can be addressed in a followup PR. cc @mischnic @DeMoorJasper |
fc51293
to
d55c33f
Compare
a0c4200
to
45b72ff
Compare
What about |
Currently we don't produce any sourcemaps for css. This PR uses PostCSS to produce sourcemaps from the CSSTransformer, CSSPackager, and CSSNanoOptimizer.
Currently a work in progress.Test Plan:
yarn test