Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove wasm-gc from RustAsset #2048

Merged
merged 3 commits into from
Sep 25, 2018
Merged

Remove wasm-gc from RustAsset #2048

merged 3 commits into from
Sep 25, 2018

Conversation

DeMoorJasper
Copy link
Member

@DeMoorJasper DeMoorJasper commented Sep 23, 2018


name: 🙋 New Pull Request
about: Do you want to change something on parcel?

↪️ Pull Request

rustc is now able to handle everything wasm-gc did according to the readme of wasm-gc therefore I made this PR removing wasm-gc.

💻 Examples

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions
  • Included links to related issues/PRs

@DeMoorJasper DeMoorJasper changed the title Remove wasm-gc from RustAsset WIP: Remove wasm-gc from RustAsset Sep 23, 2018
@DeMoorJasper DeMoorJasper changed the title WIP: Remove wasm-gc from RustAsset Remove wasm-gc from RustAsset Sep 23, 2018
@devongovett
Copy link
Member

readme also mentions a --gc-sections flag that the rust compiler supports. do we need to use that?

@devongovett
Copy link
Member

cc @alexcrichton

@alexcrichton
Copy link

Looks good to me! It's true that wasm-gc is no longer needed, and the Rust compiler automatically by default executes the equivalent of --gc-sections when creating output, so no need to pass any extra flags either!

@devongovett devongovett merged commit 6844492 into master Sep 25, 2018
@devongovett devongovett deleted the speedup-rust-asset branch September 25, 2018 03:51
devongovett pushed a commit that referenced this pull request Oct 15, 2018
devongovett pushed a commit that referenced this pull request Oct 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants