-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable/disable node-sass sourcemaps #903
Comments
This is really a feature request for CSS source maps. We should enable/disable them based on the CLI flag for sourcemaps that is already used for JS. |
@devongovett hey is cli flags still available to disable then sourcemap? // package.json
...
"scripts": {
"start": "parcel index.html --open",
"build": "parcel build index.html --no-source-maps"
},
"devDependencies": {
"parcel-bundler": "^1.6.2",
"typescript": "^2.7.2"
},
"dependencies": {
"react": "^16.2.0",
"react-dom": "^16.2.0"
}
... both local and global are 1.6.2 version. there is also no such option in help infos when I typed |
@shadeofgod the build sourcemaps haven't been released yet, they are only on the current master branch of the github repo |
@DeMoorJasper this is a little bit weird, it do generated sourcemaps at the first time when I ran build command, later after I posted here I removed whole local node_modules directory and npm install everything again, oops no more sourcemaps for the build this time. btw docs says it was enabled by default tho. |
@shadeofgod The docs is my bad, it should've said is enabled by default in watch mode, as it's not been released yet on build as I said before. |
@DeMoorJasper yeah you are right, I found it. It was generated by that thanks for your quick response! |
Enable/disable sourcemaps based on the CLI flag for sourcemaps that is already used for JS. Note that sass test are failing for now, and I don't really understand why. If someone with a deeper understanding of the Parcel code base could take a look and see what's wrong, this would help me a lot !
I've opened a PR to implement this feature: #1373 Note that sass test are failing for now, and I don't really understand why. |
Sass source maps are not working for me. |
PR coming along for this in #2489 |
👋
Is there a way to add sourcemaps support for
node-sass
?Only way i've found is to create a
.sassrc
with this config (inline-sourcemaps here) for example:But no way to disable it when running
parcel build
command.Thanks for your work.
The text was updated successfully, but these errors were encountered: