debuginfo/store: Use tracer.Start instead of SpanFromContext #3270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakkoyun
changed the title
Signed-off-by: Kemal Akkoyun <kakkoyun@gmail.com>
kakkoyun
force-pushed
the
fix_context_cancellation_errors
branch
from
c46ca46
to
f970e3c
Compare
|
I wonder if there are some implications here. Would we break the gRPC interceptor to our service implementation chain? |
Creating a new span should break any existing facilities. This API makes sure we have a new context when we passed down to call chain. |
metalmatze
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kemal Akkoyun kakkoyun@gmail.com
Since parca-agent started to create spans from the client side,
SpanFromContexthas started to create problems.Even though operations successfully finish since OTel SDK propagates the context from/to the client-side agent receives a timed-out/closed context.
This was causing errors on the agent side.
The PR ensures a new context is created, and the child context is closed when the operation is finished without touching the parent(incoming) context.
Fixes parca-dev/parca-agent#1741