Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'url' type value for report-uri #61

Merged
merged 1 commit into from
Jan 28, 2023
Merged

Add 'url' type value for report-uri #61

merged 1 commit into from
Jan 28, 2023

Conversation

danieltott
Copy link
Contributor

report-uri values are being incorrectly encoded. The enc() function takes a type parameter that was missing.

@danieltott danieltott mentioned this pull request Jan 19, 2023
Closed
@paragonie-security paragonie-security merged commit a324e23 into paragonie:master Jan 28, 2023
@paragonie-security paragonie-security mentioned this pull request Jan 29, 2023
Closed
@elliot-sawyer
Copy link

elliot-sawyer commented Mar 9, 2023 •
edited
Loading

This still doesn't work for me, using latest dev-master. I can see the 'url' parameter is used, but the value "https://localhost:8082/csp/enforce/1" still comes out as https%3A%2F%2Flocalhost%3A8082%2Fcsp%2Fenforce%2F1. If I remove the call to $this->enc(...) entirely, it works (obviously not desirable though)

Migrating back to 2.7.0 fixes my particular problem. Is there a reason the report-uri key needs to be sent through an extra encoding step?

@paragonie-security
Copy link
Contributor

Is this fixed for you in v2.8.1? https://github.com/paragonie/csp-builder/releases/tag/v2.8.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

report-uri gets wrongly encoded
3 participants
@danieltott @elliot-sawyer @paragonie-security