chore: always use new_unchecked (#89)

ref #88 (comment)
paradigmxyz · Apr 7, 2024 · 7f41c77 · 7f41c77
1 parent 5baa6b3
commit 7f41c77
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/src/tracing/js/bindings.rs b/src/tracing/js/bindings.rs
@@ -387,11 +387,9 @@ impl OpObj {
         let to_string = FunctionObjectBuilder::new(
             context.realm(),
             NativeFunction::from_copy_closure(move |_this, _args, _ctx| {
-                let op = OpCode::new(value).unwrap_or_else(|| {
-                    // unknown opcode, this could be an additional opcode that is not part of the
-                    // enum
-                    unsafe { OpCode::new_unchecked(value) }
-                });
+                // we always want an OpCode, even it is unknown because it could be an additional
+                // opcode that not a known constant
+                let op = unsafe { OpCode::new_unchecked(value) };
                 let s = op.to_string();
                 Ok(JsValue::from(js_string!(s)))
             }),

diff --git a/src/tracing/mod.rs b/src/tracing/mod.rs
@@ -345,10 +345,9 @@ impl TracingInspector {
             None
         };
 
-        let op = OpCode::new(interp.current_opcode()).unwrap_or_else(|| {
-            // unknown opcode, this could be an additional opcode that is not part of the enum
-            unsafe { OpCode::new_unchecked(interp.current_opcode()) }
-        });
+        // we always want an OpCode, even it is unknown because it could be an additional opcode
+        // that not a known constant
+        let op = unsafe { OpCode::new_unchecked(interp.current_opcode()) };
 
         trace.trace.steps.push(CallTraceStep {
             depth: context.journaled_state.depth(),