Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use non-None enveloped tx for trace_call #6136

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

Rjected
Copy link
Member

@Rjected Rjected commented Jan 19, 2024

Should hopefully fix #6008

This just sets the enveloped_tx field to Some, without setting an actual envelope. This seems to correspond with how op-geth sets the rollup env values.

@Rjected Rjected added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation A-op-reth Related to Optimism and op-reth labels Jan 19, 2024
@Rjected Rjected requested a review from mattsse as a code owner January 19, 2024 18:57
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the tx bytes is not great but should do it

@Rjected
Copy link
Member Author

Rjected commented Jan 19, 2024

the tx bytes is not great but should do it

yeah filed this on revm for the eventual tx env work there:
bluealloy/revm#995

@Rjected
Copy link
Member Author

Rjected commented Jan 19, 2024

Just confirmed that calls don't panic after this

~/p/reth (dan/evm-cfg-trait)> cast rpc --rpc-url http://base-mainnet-node:9545 trace_call --raw '[{"from": "0xd8ea779b8ffc1096ca422d40588c4c0641709890", "to": "0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b", "value": "0x186a0"}, ["trace"]]'
{"output":"0x","stateDiff":null,"trace":[{"type":"call","action":{"from":"0xd8ea779b8ffc1096ca422d40588c4c0641709890","callType":"call","gas":"0x2faf080","input":"0x","to":"0xa94f5374fce5edbc8e2a8697c15331677e6ebf0b","value":"0x186a0"},"result":{"gasUsed":"0x5208","output":"0x"},"subtraces":0,"traceAddress":[]}],"vmTrace":null}

@Rjected Rjected added this pull request to the merge queue Jan 19, 2024
Merged via the queue into main with commit 924ef8d Jan 19, 2024
27 checks passed
@Rjected Rjected deleted the dan/use-non-none-call-enveloped-tx branch January 19, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-op-reth Related to Optimism and op-reth A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Base: trace_call returns internal blocking task error
2 participants