Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return error from main when some chunks failed. #42

Merged
merged 1 commit into from
Aug 22, 2023
Merged

Return error from main when some chunks failed. #42

merged 1 commit into from
Aug 22, 2023

Conversation

kskalski
Copy link
Contributor

Motivation

When some chunk collection fails the cryo command happily returns success code and tooling can't notice failures

Solution

Return Err from main when some chunk failed

PR Checklist

  • [not applicable ] Added Tests
  • [not applicable ] Added Documentation
  • [command previously succeeded when there were errors, now it's not ] Breaking changes

@sslivkoff sslivkoff merged commit 51c8450 into paradigmxyz:main Aug 22, 2023
3 checks passed
@kskalski kskalski deleted the fix/return-on-err branch August 30, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kskalski @sslivkoff