Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terraform: downgrade python-hcl2 from 4.3.2 to 4.3.0 to work around parsing issues (Cherry-pick of #21361) #21364

Merged
merged 1 commit into from
Aug 29, 2024

Commits on Aug 29, 2024

  1. Terraform: downgrade python-hcl2 from 4.3.2 to 4.3.0 to work around p…

    …arsing issues (#21361)
    
    `python-hcl2` 4.3.1+ has some serious issues with parsing certain kinds
    of expressions, like multi-line
    ternaries. The issues opened can be seen
    [here](https://github.com/amplify-education/python-hcl2/issues?q=is%3Aissue+is%3Aopen+%22unexpected+token%22).
    
    It looks like 4.3.5 has fixed a bunch of the issues, but I'm still
    seeing some errors on our repo, and I think
    it's better to keep to 4.3.0 until the authors of the issues close them
    and we're sure there are no regressions.
    
    Also, 4.3.0 is still compatible with py3.12, so it doesn't undo the
    efforts of #20365.
    
    Generated with `pants run
    build-support/bin/generate_builtin_lockfiles.py --
    terraform-hcl2-parser`.
    purajit authored and WorkerPants committed Aug 29, 2024
    Configuration menu
    Copy the full SHA
    0605d48 View commit details
    Browse the repository at this point in the history