Remove deprecated rules #1369
Open
Remove deprecated rules #1369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love it. Do you know if we need also to do this with older IoCs? |
|
@jacknagz yeah, removing old IoCs was one of the motivators for this! We already have several IoC rules marked as deprecated that got cleaned out in this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
A number of rules in Panther are deprecated and not encouraged to be used. We have previously marked them as deprecated, but haven't had a good way to actually remove them from the repo without leaving orphaned versions on each customer's remote instance.
This PR creates a
deprecated.txtfile containing the RuleIDs of all rules we've removed. Customers can use this file to remove deprecated rules from their instances with:Changes
deprecated.txtfile and appended the rule IDs of all the deleted rulesTesting
make test,pat validate, andpat uploadall worked successfully.