Ftoppi patch 5 #541
Merged
Ftoppi patch 5 #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvrocks.conf is mounted to /kvrocks/conf/kvrocks.conf but apache/kvrocks looks for the config in /var/lib/kvrocks In addition, logging in containers is usually sent to stdout/stderr. This PR adds arguments to kvrocks to read the proper config file and override logging to stdout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm attempting to fix kvrocks in docker.
kvrocks.confis mounted to/kvrocks/conf/kvrocks.confbutapache/kvrockslooks for the config in/var/lib/kvrocksby default (https://github.com/apache/kvrocks/blob/2.8/Dockerfile), thus the config file is never used.In addition, logging in containers is usually sent to stdout/stderr.
This PR adds arguments to kvrocks to read the proper config file and log to stdout.
Since
kvrocks.confis now properly applied, kvrocks listens on port 6101. I have reverted the change toconfig/generic.json.sample.