Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added markDown Feature #60004

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dmorton714
Copy link

  • closes added markDown Feature #60004 ? (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
    • I'm not sure if you have how you implement into the code base so I just gave use case examples
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

I am new to adding features and working with anything this extensive. I didn't realize to_markdown() was a function so I made my own. It also doesn't require tabulate and is around 40% fasters in my tests. Looking forward to any feedback.

Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, but we would require an issue to discuss the feature request (replacing tablulate with your implementation). This PR would also need to demonstrate that your function passes all the markdown tests.

IMO it's probably unlikely that this would be accepted into pandas since this would incur maintenance burden which was handled by tabulate. Might I suggest submitting a pull request to tabulate proposing your performance improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants