Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST (string dtype): remove usage of arrow_string_storage fixture #59368

Conversation

jorisvandenbossche
Copy link
Member

This removes one other use of "pyarrow_numpy" in the tests.

This essentially reverts #54535, because we now again can check `.storage == "pyarrow" for both dtype variants that use pyarrow as storage.

xref #54792

@jorisvandenbossche jorisvandenbossche added Testing pandas testing functions or related to the test suite Strings String extension data type and string data labels Jul 31, 2024
@mroeschke mroeschke added this to the 3.0 milestone Jul 31, 2024
@mroeschke mroeschke merged commit 4b4c86e into pandas-dev:main Jul 31, 2024
39 of 45 checks passed
@mroeschke
Copy link
Member

Thanks @jorisvandenbossche

@jorisvandenbossche jorisvandenbossche deleted the string-dtype-tests-fixtures-arrow_string_storage branch July 31, 2024 18:28
WillAyd pushed a commit that referenced this pull request Aug 13, 2024
)

* TST (string dtype): remove usage of arrow_string_storage fixture

* fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 14, 2024
…das-dev#59368)

* TST (string dtype): remove usage of arrow_string_storage fixture

* fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 15, 2024
…das-dev#59368)

* TST (string dtype): remove usage of arrow_string_storage fixture

* fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 15, 2024
…das-dev#59368)

* TST (string dtype): remove usage of arrow_string_storage fixture

* fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 15, 2024
…das-dev#59368)

* TST (string dtype): remove usage of arrow_string_storage fixture

* fixup
@jorisvandenbossche jorisvandenbossche modified the milestones: 3.0, 2.3 Aug 20, 2024
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 21, 2024
…das-dev#59368)

* TST (string dtype): remove usage of arrow_string_storage fixture

* fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 22, 2024
…das-dev#59368)

* TST (string dtype): remove usage of arrow_string_storage fixture

* fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 22, 2024
…das-dev#59368)

* TST (string dtype): remove usage of arrow_string_storage fixture

* fixup
WillAyd pushed a commit to WillAyd/pandas that referenced this pull request Aug 27, 2024
…das-dev#59368)

* TST (string dtype): remove usage of arrow_string_storage fixture

* fixup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Strings String extension data type and string data Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants