Fix https://github.com/pandas-dev/pandas/issues/20608 #59284
+14
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
reviewed
Jul 23, 2024
rhshadrach
added
Bug
Dtype Conversions
rhshadrach
reviewed
Aug 1, 2024
| @@ -1221,7 +1222,7 @@ def _try_convert_data( | |||
| if len(data) and data.dtype in ("float", "object"): | |||
| # coerce ints if we can | |||
| try: | |||
| new_data = data.astype("int64") | |||
| new_data = backup_data.astype("int64") | |||
There was a problem hiding this comment.
Instead of this, it seems to me we should first try to convert the data to integer on L1206 above, then if that fails try float. That way we aren't converting to float then back to int unnecessarily.
There was a problem hiding this comment.
if we do int first and then float. It will create issue for decimals. eg: 25.5 will become 25
rhshadrach
requested changes
Aug 1, 2024
|
This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this. |
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.