ENH: DataFrame.plot.scatter argument c now accepts a column of strings, where rows with the same string are colored identically
#59239
+65
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
import pandas as pd
import random as rand
df = pd.DataFrame({
'dataX': [rand.randint(0, 100) for _ in range(100)],
'dataY': [rand.randint(0, 100) for _ in range(100)],
'fav_fruit': [rand.choice(['Apples', 'Bananas', 'Grapes', 'Peaches']) for _ in range(100)],
})
df.plot.scatter('dataX', 'dataY', c='fav_fruit')
|
added 2 commits
July 12, 2024 23:28
michaelmannino
changed the title
c now accepts a column of strings, where rows with the same string are colored identically
WillAyd
requested changes
Jul 26, 2024
| @@ -1390,6 +1407,38 @@ def _get_c_values(self, color, color_by_categorical: bool, c_is_column: bool): | |||
| c_values = c | |||
| return c_values | |||
|
|
|||
| def _are_valid_colors(self, c_values: np.ndarray | list): | |||
There was a problem hiding this comment.
In what instances is c_values a list? Might be misreading but would be better if we only worked with a pd.Series and could call .unique on that, instead of checking every single value in a loop
| except (TypeError, ValueError) as _: | ||
| return False | ||
|
|
||
| def _uniquely_color_strs( |
There was a problem hiding this comment.
I am no matplotlib expert but I think we need to defer to that somehow to get the desired colors, instead of trying to write this out ourselves
Dr-Irv
requested changes
Jul 26, 2024
Comment on lines
+220
to
+221
| with tm.assert_produces_warning(None): | ||
| ax = df.plot.scatter(x=0, y=1, c="state") |
There was a problem hiding this comment.
I'm not 100% sure that the test here should be in the tm.assert_produces_warning(None) context. My intuition is that should be removed.
There should also be tests where the column state contains values that are colors, as well as a mix of colors and non-colors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.