ENH: support argmin/max, idxmin/max with object dtype #54109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Jul 13, 2023
| @@ -1070,27 +1071,89 @@ def test_timedelta64_analytics(self): | |||
| (Series(["foo", "foo", "bar", "bar", None, np.nan, "baz"]), TypeError), | |||
| ], | |||
| ) | |||
| def test_assert_idxminmax_raises(self, test_input, error_type): | |||
| def test_assert_idxminmax_empty_raises(self, test_input, error_type): | |||
There was a problem hiding this comment.
It looks like error_type can be removed from the parametrization now?
mroeschke
reviewed
Jul 13, 2023
| ser3 = Series(["foo", "foo", "bar", "bar", None, np.nan, "baz"]) | ||
| msg = "'>' not supported between instances of 'float' and 'str'" | ||
| with pytest.raises(TypeError, match=msg): | ||
| ser3.idxmax() |
There was a problem hiding this comment.
So with object dtype, na-like values are not considered "missing" and rather object scalars so skipna=True has no effect here?
There was a problem hiding this comment.
the skipping part is done after the np.argmin/np.argmax is done, so that can still raise
mroeschke
approved these changes
Jul 17, 2023
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Agreed upon in yesterday's call.