Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: Remove int64 uint64 float64 index tests #50479

Conversation

topper-123
Copy link
Contributor

@topper-123 topper-123 commented Dec 28, 2022

This PR updates various tests that currently use Int64Index/UInt64Index/Float64Index to instead use Index with the relevant dtype (parametrized dtypes where relevant). Sections of the tests suite are changed in separate commits, so it will be easier to separate them out, if desired.

This PR's first 3 commits correspond to #50052, which again build on #49560, which builds on #50195. Those 3 PRs are not part of this PR, but should ideally be treated as precursors for this PR, if possible.

@topper-123 topper-123 force-pushed the remove_int64_uint64_float64_index_tests branch 2 times, most recently from ab5f69c to 54fe9b5 Compare January 1, 2023 23:32
@topper-123 topper-123 marked this pull request as ready for review January 3, 2023 08:20
@topper-123 topper-123 force-pushed the remove_int64_uint64_float64_index_tests branch from 54fe9b5 to 368ca06 Compare January 3, 2023 08:29
@jbrockmendel
Copy link
Member

needs rebase

@topper-123
Copy link
Contributor Author

Yeah, this builds on top of #49560. If I can get that PR in, I will update this (and proceed with other remaining Int/Uint/Float64Index removal.

@topper-123 topper-123 force-pushed the remove_int64_uint64_float64_index_tests branch from 368ca06 to bc7911e Compare January 15, 2023 16:06
@topper-123 topper-123 force-pushed the remove_int64_uint64_float64_index_tests branch from bc7911e to 4731a95 Compare January 15, 2023 17:42
@topper-123
Copy link
Contributor Author

topper-123 commented Jan 19, 2023

Superseded by various other PRs.

@topper-123 topper-123 closed this Jan 19, 2023
@topper-123 topper-123 deleted the remove_int64_uint64_float64_index_tests branch January 22, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants