Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TYPE: Move any all to _typing #48300

Merged
merged 1 commit into from
Aug 29, 2022
Merged

TYPE: Move any all to _typing #48300

merged 1 commit into from
Aug 29, 2022

Conversation

phofl
Copy link
Member

@phofl phofl commented Aug 29, 2022

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

cc @mroeschke @twoertwein

@phofl phofl added the Typing type annotations, mypy/pyright type checking label Aug 29, 2022
jbrockmendel
jbrockmendel approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@jbrockmendel jbrockmendel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mroeschke mroeschke added this to the 1.6 milestone Aug 29, 2022
@mroeschke mroeschke merged commit 707039a into pandas-dev:main Aug 29, 2022
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the typ_any_all branch August 30, 2022 07:46
@mroeschke mroeschke modified the milestones: 1.6, 2.0 Oct 13, 2022
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@phofl @noatamir
TYPE: Move any all to _typing (pandas-dev#48300)
52fdb48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@phofl @mroeschke @jbrockmendel