Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: set_index copy kwd #48043

Merged
merged 3 commits into from
Aug 12, 2022
Merged

ENH: set_index copy kwd #48043

merged 3 commits into from
Aug 12, 2022

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the Github issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke added this to the 1.5 milestone Aug 12, 2022
@mroeschke mroeschke merged commit 9716fcb into pandas-dev:main Aug 12, 2022
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the perf-set_index-copy branch August 13, 2022 17:59
@jbrockmendel jbrockmendel mentioned this pull request Aug 18, 2022
Closed
YYYasin19 pushed a commit to YYYasin19/pandas that referenced this pull request Aug 23, 2022
@jbrockmendel @YYYasin19
ENH: set_index copy kwd (pandas-dev#48043)
0892fa4 
* ENH: set_index copy kwd

* GH ref

* mypy fixup
jorisvandenbossche added a commit to jorisvandenbossche/pandas that referenced this pull request Sep 6, 2022
@jorisvandenbossche
Revert "ENH: set_index copy kwd (pandas-dev#48043)"
d2539ef 
This reverts commit 9716fcb.
@jorisvandenbossche jorisvandenbossche mentioned this pull request Sep 6, 2022
Merged
mroeschke pushed a commit that referenced this pull request Sep 14, 2022
@jorisvandenbossche
Revert set_index inplace and copy keyword changes (#48417)
a551f1b 
* Revert "DEPR: inplace kwarg in set_index (#48115)"

This reverts commit 9de1f0b.

* Revert "ENH: set_index copy kwd (#48043)"

This reverts commit 9716fcb.

* fixup merge of whatsnew file
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@jbrockmendel @noatamir
ENH: set_index copy kwd (pandas-dev#48043)
b431eee 
* ENH: set_index copy kwd

* GH ref

* mypy fixup
noatamir pushed a commit to noatamir/pandas that referenced this pull request Nov 9, 2022
@jorisvandenbossche @noatamir
Revert set_index inplace and copy keyword changes (pandas-dev#48417)
db849e7 
* Revert "DEPR: inplace kwarg in set_index (pandas-dev#48115)"

This reverts commit 9de1f0b.

* Revert "ENH: set_index copy kwd (pandas-dev#48043)"

This reverts commit 9716fcb.

* fixup merge of whatsnew file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
1.5
Development

Successfully merging this pull request may close these issues.
2 participants
@jbrockmendel @mroeschke