ENH: add render_links for Styler.to_html formatting #45058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Dec 24, 2021
mroeschke
reviewed
Dec 24, 2021
|
Please note I added the LaTeX equivalent, so the signature is now consistent with the Also note I changed the argument name to |
jreback
requested changes
Dec 27, 2021
| @@ -798,6 +798,7 @@ def format( | |||
| decimal: str = ".", | |||
| thousands: str | None = None, | |||
| escape: str | None = None, | |||
| hyperlinks: str | None = None, | |||
There was a problem hiding this comment.
is there a reason we prefer this to render_links?
There was a problem hiding this comment.
My arguments: hyperlink is a bit more specific whereas link can be a general term in certain contexts. And, technically, everything is rendered so why not add render to every kwarg. And rendering is somewhat of an esoteric concept outside of graphics processing.
jreback
approved these changes
Dec 28, 2021
|
thanks @attack68 |
|
i was not sure if there was an actual issue for this (aside from the discussion), if so can you link. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came about as a requirement for converting DataFrame.to_html into Styler.to_html, citing @jorisvandenbossche in favour of the functionality.
Note that the
DataFrame.to_htmlrender_linksargument is rather limited to just detecting only a URL in a cell.The function added for Styler here is a more general pattern search, and it allows the result to be viewed in Jupyter Notebook directly, which the precursor does not.