Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN: helper attribute to check for ArrayManager #44676

Conversation

jorisvandenbossche
Copy link
Member

@jbrockmendel
Copy link
Member

grepping for hasattr.*blocks shows a few more places this can be used

@jreback
Copy link
Contributor

jreback commented Dec 1, 2021

@jorisvandenbossche
Copy link
Member Author

jorisvandenbossche commented Dec 1, 2021

Any suggestion how to deal with this? Because if mypy doesn't understand the helper function, that basically means that you need to add a cast (or ignore comment) every time this is used ..

@jbrockmendel
Copy link
Member

Any suggestion how to deal with this? Because if mypy doesn't understand the helper function, that basically means that you need to add a cast (or ignore comment) every time this is used ..

  1. type: ignore
  2. add a blocks property to AM that raises NotImplementedError
  3. ping @simonjayhawkins

@jreback jreback removed this from the 1.4 milestone Dec 23, 2021
@github-actions
Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Feb 14, 2022
@simonjayhawkins
Copy link
Member

I assume would need to make DataFrame Generic and add the _mgr class as a type parameter. Since _mgr is private, not sure it this would be best practice from a typing perspective as the DataFrame typing is public.

https://mypy.readthedocs.io/en/stable/generics.html#generics

@simonjayhawkins
Copy link
Member

Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants