BUG: of apply function of DataFrame reported in issues #39166 #39296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmishra01
commented
Jan 20, 2021
•
jmishra01
commented
- closes BUG: .apply with collections #39166
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
added 2 commits
January 20, 2021 20:00
jmishra01
changed the title
jmishra01
changed the title
jreback
requested changes
Jan 20, 2021
jreback
changed the title
| @@ -530,7 +530,8 @@ def series_generator(self): | |||
| ser._mgr = mgr | |||
| blk.values = arr | |||
| ser.name = name | |||
| yield ser | |||
| # To fix issue of #39166 | |||
| yield ser.copy() | |||
There was a problem hiding this comment.
the entire point of series_generator is to avoid creating a bunch of Series objects. if this is too buggy to be viable, might as well remove the whole method and just use self.obj.iloc[i] for i in range(len(self.obj))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.