Revert "Inconsistent indexes for tick label plotting (#28733)" #39235
Conversation
This reverts commit fb379d8.
doc/source/whatsnew/v1.2.1.rst
Outdated
| @@ -12,6 +12,10 @@ including other versions of pandas. | |||
|
|
|||
| .. _whatsnew_121.regressions: | |||
|
|
|||
| We have reverted a commit that resulted in several plotting related regressions in pandas 1.2 (:issue:`38969`, :issue:`38736`, :issue:`38865`, :issue:`38947` and :issue:`39126`) | |||
|
|
|||
| As a result, bugs reported as fixed in pandas 1.2 are again present (:issue:`26186` and :issue:`11465`) | |||
There was a problem hiding this comment.
I would move this below the list of regressions below? (now it's not under the "Fixed regressions" title)
There was a problem hiding this comment.
we didn't actually 'fix', but will defer to you on documentation layout.
There was a problem hiding this comment.
The regressions are still fixed, no? (although tests are not yet added, I am assuming this fixed the regression reports)
There was a problem hiding this comment.
I see your point. I sort of meant we didn't fix as we broke other things. but maybe regression section is more appropriate than the introductory sentences.
doc/source/whatsnew/v1.2.0.rst
Outdated
| @@ -751,6 +751,7 @@ Plotting | |||
|
|
|||
| - Bug in :meth:`DataFrame.plot` was rotating xticklabels when ``subplots=True``, even if the x-axis wasn't an irregular time series (:issue:`29460`) | |||
| - Bug in :meth:`DataFrame.plot` where a marker letter in the ``style`` keyword sometimes caused a ``ValueError`` (:issue:`21003`) | |||
| - Bug in :meth:`DataFrame.plot.bar` and :meth:`Series.plot.bar` where ticks positions were assigned by value order instead of using the actual value for numeric or a smart ordering for string (:issue:`26186`, :issue:`11465`) | |||
There was a problem hiding this comment.
Maybe add something here like: This fix has been reverted in pandas 1.2.1, see :doc:`v1.2.1` "
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
Co-authored-by: Joris Van den Bossche <jorisvandenbossche@gmail.com>
|
thanks @simonjayhawkins |
|
@meeseeksdev backport 1.2.x |
|
Something went wrong ... Please have a look at my logs. |
This reverts commit fb379d8.
reverts #28733
cc @nrebena @jreback @WillAyd @charlesdong1991
just the complete revert for now for ci testing, will add commits for release notes. will NOT add regression tests see #38721 (comment)