TST: tighten xfails #38309
Merged
TST: tighten xfails #38309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Dec 5, 2020
| # test ufuncs of numpy, see: | ||
| # https://numpy.org/doc/stable/reference/ufuncs.html | ||
|
|
||
| if isinstance(index, (DatetimeIndex, TimedeltaIndex)): | ||
| if isinstance(index, DatetimeIndex) and index.tz is not None: | ||
| if func in [np.isfinite, np.isnan, np.isinf]: | ||
| pytest.xfail(reason="__array_ufunc__ is not defined") | ||
| if not np_version_under1p17: |
There was a problem hiding this comment.
why do we not prefer an inside use of pytest.xfail and this format instead?
There was a problem hiding this comment.
using pytest.xfail breaks out immediately, so you dont get alerted if the xfail has been fixed.
There was a problem hiding this comment.
interesting; it doesn't react to strict=True?
There was a problem hiding this comment.
AFAIK thats only when used as a decorator @pytest.mark.xfail(strict=foo)
There was a problem hiding this comment.
kk
can u update the way to write tests in the docs (open an issue or PR)
also prob need to have a rule which prohibits (open an issue)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.