TYP: datetimelike #38307
Merged
TYP: datetimelike #38307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Dec 7, 2020
| @@ -755,28 +760,30 @@ def isin(self, values) -> np.ndarray: | |||
| # ------------------------------------------------------------------ | |||
| # Null Handling | |||
|
|
|||
| def isna(self): | |||
| def isna(self) -> np.ndarray: | |||
There was a problem hiding this comment.
we dont' have the typing ability to do np.ndarray[bool] yet right?
There was a problem hiding this comment.
looks like will be in numpy 1.21 numpy/numpy#17719
| @@ -996,7 +1006,7 @@ def _add_timedeltalike_scalar(self, other): | |||
| if isna(other): | |||
| # i.e np.timedelta64("NaT"), not recognized by delta_to_nanoseconds | |||
| new_values = np.empty(self.shape, dtype="i8") | |||
| new_values[:] = iNaT | |||
| new_values.fill(iNaT) | |||
There was a problem hiding this comment.
followon ok too (as many places where this is done), though prob easy to do here
There was a problem hiding this comment.
yah, we use .fill way more often, to the point that i sometimes forget that np.full is a thing
jreback
added
Datetime
|
might actually be some perf boosts here due to using putmask |
yep thats the idea |
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use np.putmask in a few places, as it is appreciably more performant than
__setitem__