Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing dict calls #38276

Merged
merged 3 commits into from
Dec 4, 2020
Merged

Conversation

joao-zanutto
Copy link
Contributor

Removed the dict calls for the files:

./pandas/core/arrays/floating.py
./pandas/core/arrays/numpy_.py
./pandas/core/arrays/interval.py

Copy link
Member

@arw2019 arw2019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for doing this!

There's pre-commit failure (styling issue)

@joao-zanutto
Copy link
Contributor Author

@arw2019 thanks for your attention! I have used flake8 for the three files that I modified and it returned nothing for me, can you help me on how I can solve this issue?

@arw2019
Copy link
Member

arw2019 commented Dec 3, 2020

@arw2019 thanks for your attention! I have used flake8 for the three files that I modified and it returned nothing for me, can you help me on how I can solve this issue?

if you run the precommit tool locally it will take care of this

@joao-zanutto
Copy link
Contributor Author

Hey @arw2019 looks like my modifications passed the checks by removing the conflict with another branch. Thanks for your help.

@jreback jreback added the Code Style Code style, linting, code_checks label Dec 4, 2020
@jreback jreback added this to the 1.2 milestone Dec 4, 2020
@jreback jreback merged commit 3359286 into pandas-dev:master Dec 4, 2020
@jreback
Copy link
Contributor

jreback commented Dec 4, 2020

thanks @zanuttin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants