Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: groupby.apply on the NaN group drops values with original axes return #38257

Merged
merged 4 commits into from
Dec 4, 2020
Merged

BUG: groupby.apply on the NaN group drops values with original axes return #38257

merged 4 commits into from
Dec 4, 2020

Conversation

GYHHAHA
Copy link
Contributor

@GYHHAHA GYHHAHA commented Dec 3, 2020 •
edited
Loading

@pep8speaks
Copy link

pep8speaks commented Dec 3, 2020 •
edited
Loading

Hello @GYHHAHA! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-12-03 08:24:42 UTC

@GYHHAHA GYHHAHA changed the title BUG: groupby.apply on the NaN group drops values when returning the same axes as the original frame BUG: groupby.apply on the NaN group drops values with original axes return Dec 3, 2020
@jreback jreback added this to the 1.2 milestone Dec 4, 2020
@jreback jreback added Bug Groupby Apply Apply, Aggregate, Transform, Map labels Dec 4, 2020
@jreback jreback merged commit 03e5858 into pandas-dev:master Dec 4, 2020
@jreback
Copy link
Contributor

jreback commented Dec 4, 2020

thanks @GYHHAHA very nice, keep em coming!

@GYHHAHA GYHHAHA deleted the fix-apply branch December 8, 2020 00:39
@simonjayhawkins simonjayhawkins mentioned this pull request Aug 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Apply Apply, Aggregate, Transform, Map Bug Groupby
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

BUG: values are dropped when grouping on a variables with NaNs
3 participants
@GYHHAHA @pep8speaks @jreback