Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to use conda-forge compilers #38219

Merged
merged 1 commit into from
Dec 2, 2020

Conversation

xhochy
Copy link
Contributor

@xhochy xhochy commented Dec 1, 2020

Additionally I switched to the miniforge3 image as this bases its installation on conda-forge
and I also have used mamba to install the environment as this massively saves time.

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

Additionally I switched to the miniforge3 image as this bases its installation on conda-forge
and I also have used `mamba` to install the environment as this massively saves time.
@xhochy
Copy link
Contributor Author

xhochy commented Dec 1, 2020

I'm not really sure where this is used / why this is useful but as it seems that it is broken and people seem to use it somehow, I gave it some love.

@jreback jreback added the Build Library building on various platforms label Dec 2, 2020
@jreback jreback added this to the 1.2 milestone Dec 2, 2020
@jreback
Copy link
Contributor

jreback commented Dec 2, 2020

yeah this is fine. I don't think we are actively using this, assume you have tested it?

@xhochy
Copy link
Contributor Author

xhochy commented Dec 2, 2020

yeah this is fine. I don't think we are actively using this, assume you have tested it?

Yes, tested and works.

@jreback jreback merged commit a48957b into pandas-dev:master Dec 2, 2020
@jreback
Copy link
Contributor

jreback commented Dec 2, 2020

thanks @xhochy

@xhochy xhochy deleted the fix-compilers-in-dockerimage branch December 2, 2020 19:41
@yehoshuadimarsky
Copy link
Contributor

just saw this, FWIW I use this, to get an isolated environment for working on pandas. Especially if I'm on Windows and want to use the Linux shell, thanks @xhochy for the update

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants