Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected the grammar in Exception #38216

Merged
merged 2 commits into from
Dec 10, 2020
Merged

Corrected the grammar in Exception #38216

merged 2 commits into from
Dec 10, 2020

Conversation

imaskm
Copy link
Contributor

@imaskm imaskm commented Dec 1, 2020

Exception on different arrays' length corrected

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@imaskm
Corrected the grammar in Exception
7d617f0 
Exception on different arrays' length corrected
jreback
jreback requested changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this message is checked in a test, pls find and change it as well (see the CI logs)

@jreback jreback added the Error Reporting Incorrect or improved errors from pandas label Dec 2, 2020
@imaskm
Copy link
Contributor Author

imaskm commented Dec 2, 2020

@jreback , I have updated the message in 2 other files.

@mroeschke mroeschke added this to the 1.3 milestone Dec 8, 2020
@imaskm
Copy link
Contributor Author

imaskm commented Dec 9, 2020

@jreback can you merge this MR?

@mroeschke mroeschke merged commit 2ff1370 into pandas-dev:master Dec 10, 2020
@mroeschke
Copy link
Member

Thanks @imaskm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback requested changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Error Reporting Incorrect or improved errors from pandas
Projects
None yet
Milestone
1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@imaskm @mroeschke @jreback