Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite dict literal for files in tests/groupby & ./pandas/tests/dtypes #38205

Merged
merged 3 commits into from
Dec 2, 2020
Merged

Rewrite dict literal for files in tests/groupby & ./pandas/tests/dtypes #38205

merged 3 commits into from
Dec 2, 2020

Conversation

Qbiwan
Copy link
Contributor

@Qbiwan Qbiwan commented Dec 1, 2020 •
edited by MarcoGorelli
Loading

./pandas/tests/dtypes/test_inference.py
./pandas/tests/groupby/test_function.py
./pandas/tests/groupby/transform/test_transform.py

@pep8speaks
Copy link

pep8speaks commented Dec 1, 2020 •
edited
Loading

Hello @Qbiwan! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-12-01 13:35:16 UTC

@MarcoGorelli
Copy link
Member

Thanks @Qbiwan - looks like there's some pre-commit failures, can you fix them up?

pre-commit run --files pandas/tests/dtypes/test_inference.py pandas/tests/groupby/test_function.py pandas/tests/groupby/transform/test_transform.py

@Qbiwan
Copy link
Contributor Author

Qbiwan commented Dec 1, 2020

@MarcoGorelli thanks, i think it is passing pre-commit now

MarcoGorelli
MarcoGorelli approved these changes Dec 1, 2020
View reviewed changes
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Qbiwan , looks good to me pending green, errors are unrelated

@jreback jreback added the Code Style Code style, linting, code_checks label Dec 2, 2020
@jreback jreback added this to the 1.2 milestone Dec 2, 2020
@jreback jreback merged commit 44f0e32 into pandas-dev:master Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcoGorelli MarcoGorelli MarcoGorelli approved these changes

Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@Qbiwan @pep8speaks @MarcoGorelli @jreback