Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: name attr in RangeIndex.intersection #38197

Merged
merged 3 commits into from
Dec 2, 2020

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Nov 30, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

@jbrockmendel
Copy link
Member Author

after #38111 will update the whatsnew from there to include this

@jbrockmendel
Copy link
Member Author

@jreback did something break the npdev build again while i wasnt looking?

@jreback
Copy link
Contributor

jreback commented Dec 1, 2020

i wonder if this is the backport of the 2d indexing message (just merged to 1.1.5)

@jbrockmendel
Copy link
Member Author

yah its just a complaint about a mismatched exception message in the 2d indexing case

pandas/conftest.py Show resolved Hide resolved
@jreback jreback added the Refactor Internal refactoring of code label Dec 2, 2020
@jreback jreback added this to the 1.2 milestone Dec 2, 2020
@jreback
Copy link
Contributor

jreback commented Dec 2, 2020

can you rebase (and update the fixture name)

@jbrockmendel
Copy link
Member Author

rebased with whatsnew

@jreback
Copy link
Contributor

jreback commented Dec 2, 2020

looks fine. waiting on CI.

@jbrockmendel
Copy link
Member Author

greenish

@simonjayhawkins
Copy link
Member

re-run and green

@jreback jreback merged commit dffab1f into pandas-dev:master Dec 2, 2020
@jbrockmendel jbrockmendel deleted the bug-ri-intersection branch December 2, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactor Internal refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants