CI: update tests for numpy 1.20 change to floordiv #38172
Conversation
|
Yikes, I got this passing, but i have no earthly idea what is going on in the Sparse tests |
| if mask.any(): | ||
| expected[mask] = np.nan | ||
| condition = _np_version_under1p20 | ||
| if isinstance(a_dense, np.ndarray) and isinstance(b_dense, np.ndarray): |
There was a problem hiding this comment.
can you add some comments here on what is changed, it is non-obvious from inspection what is changing (e.g. what is true in prior version and what is true now)
There was a problem hiding this comment.
yah as mentioned above, i have no frikkin idea what the underlying logic is here
| condition = _np_version_under1p20 | ||
| if isinstance(a_dense, np.ndarray) and isinstance(b_dense, np.ndarray): | ||
| condition = True | ||
| if a_dense.dtype == np.float64 and np.isnan(a.fill_value): |
jreback
added
the
Compat
|
can we push an xfail for this case for now? (and debug / followup with this PR later). |
|
failing on 1.1.x as well, so will want to try to backport this. |
|
agreed with the above |
|
updated to xfail |
|
narrowed down the xfails a little bit |
| @@ -29,7 +31,7 @@ class TestSparseArrayArithmetics: | |||
| def _assert(self, a, b): | |||
| tm.assert_numpy_array_equal(a, b) | |||
|
|
|||
| def _check_numeric_ops(self, a, b, a_dense, b_dense, mix, op): | |||
| def _check_numeric_ops(self, a, b, a_dense, b_dense, mix, op, flag=False): | |||
There was a problem hiding this comment.
leftover from previous attempt at a fix, will remove
|
thanks @jbrockmendel (feel free to open an issue to address this, no hurry now). |
|
@meeseeksdev backport 1.1.x |
#38191) Co-authored-by: jbrockmendel <jbrockmendel@gmail.com>
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffLooks like numpy/numpy#16161 changed numpy's floordiv behavior