BUG: unexpected merge_ordered results caused by wrongly groupby #38170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
approved these changes
Dec 2, 2020
| @@ -274,10 +271,20 @@ def _merger(x, y): | |||
| if left_by is not None and right_by is not None: | |||
| raise ValueError("Can only group either left or right frames") | |||
| elif left_by is not None: | |||
| if isinstance(left_by, str): | |||
There was a problem hiding this comment.
its possible that we want to integrate these checks much more into: https://github.com/pandas-dev/pandas/blob/master/pandas/core/reshape/merge.py#L1247
but this may require some refactoring. (as a followup if you can)
|
thanks @GYHHAHA very nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff