REF: implement _ea_wrap_cython_operation #38162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
| return result, names | ||
|
|
||
| elif is_integer_dtype(values.dtype) or is_bool_dtype(values.dtype): | ||
| # IntegerArray or BooleanArray |
There was a problem hiding this comment.
This should probably also handle FloatingArray?
There was a problem hiding this comment.
yes, ive got a branch doing that right now, hopefully will make a PR today.
There was a problem hiding this comment.
OK, yes please try to do that shortly, as that should go into 1.2 ideally (before this PR, FloatArray was going through the cython groupby algos, but now not anymore)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've identified some bugs in _cython_operation. As a preliminary to fixing them, this splits out the EA-handling from the ndarray-handling. This will also make it easier to keep track of what we need to generalize if we want this to support arbitrary EAs.