ENH: add "schema" kwarg to io.sql.get_schema method #38146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arw2019
changed the title
5 tasks
|
lgtm. @jorisvandenbossche if you can give a once over |
…28486-add_schema_kwarg
…28486-add_schema_kwarg
mroeschke
reviewed
Dec 6, 2020
doc/source/whatsnew/v1.2.0.rst
Outdated
| @@ -260,6 +260,7 @@ Other enhancements | |||
| - Added :meth:`~DataFrame.set_flags` for setting table-wide flags on a Series or DataFrame (:issue:`28394`) | |||
| - :meth:`DataFrame.applymap` now supports ``na_action`` (:issue:`23803`) | |||
| - :class:`Index` with object dtype supports division and multiplication (:issue:`34160`) | |||
| - :meth:`get_schema` now allows a schema kwarg that will add a schema into the create table statement (:issue:`28486`) | |||
There was a problem hiding this comment.
Mind specifying io.sql.get_schema directly?
mroeschke
reviewed
Dec 6, 2020
…28486-add_schema_kwarg
mroeschke
approved these changes
Dec 7, 2020
jreback
requested changes
Dec 7, 2020
| @@ -1873,4 +1896,6 @@ def get_schema(frame, name, keys=None, con=None, dtype=None): | |||
|
|
|||
| """ | |||
| pandas_sql = pandasSQL_builder(con=con) | |||
| return pandas_sql._create_sql_schema(frame, name, keys=keys, dtype=dtype) | |||
| return pandas_sql._create_sql_schema( | |||
There was a problem hiding this comment.
oh you need to update doc-string and add versionadded 1.2
jreback
approved these changes
Dec 7, 2020
|
lgtm ping on green |
|
Green |
|
Thanks @arw2019 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diffPicking up #33278