Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF: replace_list #38097

Merged
merged 1 commit into from
Nov 27, 2020
Merged

PERF: replace_list #38097

merged 1 commit into from
Nov 27, 2020

Conversation

jbrockmendel
Copy link
Member

@jbrockmendel jbrockmendel commented Nov 26, 2020

  • closes #xxxx
  • tests added / passed
  • passes black pandas
  • passes git diff upstream/master -u -- "*.py" | flake8 --diff
  • whatsnew entry

closes #38086, this gets us back to (very slightly ahead of) 1.1.4 performance for the cases there, will leave to @jorisvandenbossche whether that is enough to close the issue.

@jreback jreback added the Performance Memory or execution speed performance label Nov 26, 2020
@jreback jreback added this to the 1.2 milestone Nov 26, 2020
@jreback jreback added the Regression Functionality that used to work in a prior pandas version label Nov 26, 2020
@jreback jreback merged commit 45ac7da into pandas-dev:master Nov 27, 2020
@jbrockmendel jbrockmendel deleted the perf-replace branch November 27, 2020 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Memory or execution speed performance Regression Functionality that used to work in a prior pandas version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PERF: performance regression in replace() corner cases
2 participants