BUG: merge_ordered fails with list-like left_by or right_by #38089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GYHHAHA
changed the title
jreback
requested changes
Nov 26, 2020
| # GH 35269 | ||
| left = DataFrame({"G": ["g", "g"], "H": ["h", "h"], "T": [1, 3]}) | ||
| right = DataFrame({"T": [2], "E": [1]}) | ||
| result = merge_ordered(left, right, on=["T"], left_by=["G", "H"]) |
There was a problem hiding this comment.
can you test the same with on='T'
also can you test with right_by
|
There also exists two parts should be fixed. >>>l = pd.DataFrame([['g', 'h', 1], ['g', 'h', 3]], columns=list('GHT'))
>>>l
G H T
0 g h 1
1 g h 3
>>>r = pd.DataFrame([[2, 1]], columns=list('TE'))
>>>r
T E
0 2 1First, the following unexpected left join is related to wrongly >>>pd.merge_ordered(l, r, on='T', left_by=['G'])
Second, unexpected result appears when unseen label exists in >>>pd.merge_ordered(l, r, on='T', left_by=['G', 'h'])
Since they are different bugs from the current list-like issue, thus I will make another PR for the above-mentioned two after this merged. |
jreback
requested changes
Nov 28, 2020
| # GH 35269 | ||
| left = DataFrame({"G": ["g", "g"], "H": ["h", "h"], "T": [1, 3]}) | ||
| right = DataFrame({"T": [2], "E": [1]}) | ||
| result1 = merge_ordered(left, right, on=["T"], left_by=["G", "H"]) |
There was a problem hiding this comment.
can you parameterize this test with the cases
|
failures from |
|
thanks @GYHHAHA very nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black pandasgit diff upstream/master -u -- "*.py" | flake8 --diff