Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Clean .ix references in indexing.rst #38080

Merged
merged 3 commits into from
Nov 26, 2020

Conversation

topper-123
Copy link
Contributor

@topper-123 topper-123 commented Nov 26, 2020

DataFrame.ix is removed from the code base, so rephrase a section in the docs that was referencing it.

@topper-123 topper-123 changed the title Clean ix references in indexing.rst DOC: Clean .ix references in indexing.rst Nov 26, 2020
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

It seems you have picked another commit

doc/source/user_guide/indexing.rst Show resolved Hide resolved
@@ -627,6 +627,7 @@ Indexing
- Bug in :meth:`DataFrame.loc` raising ``TypeError`` when non-integer slice was given to select values from :class:`MultiIndex` (:issue:`25165`, :issue:`24263`)
- Bug in :meth:`DataFrame.loc` returning and assigning elements in wrong order when indexer is differently ordered than the :class:`MultiIndex` to filter (:issue:`31330`, :issue:`34603`)
- Bug in :meth:`DataFrame.loc` and :meth:`DataFrame.__getitem__` raising ``KeyError`` when columns were :class:`MultiIndex` with only one level (:issue:`29749`)
- Bug in :meth:`Series.__getitem__` and :meth:`DataFrame.__getitem__` raising blank ``KeyError`` without missing keys for :class:`IntervalIndex` (:issue:`27365`)
Copy link
Member

@phofl phofl Nov 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird that this is mentioned as change. That is from one of mine PRs which was merged a few hours ago. Same for the following changes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a rebasing bug. I've fixed it now.

@jreback jreback added this to the 1.2 milestone Nov 26, 2020
@jreback jreback merged commit 43fa160 into pandas-dev:master Nov 26, 2020
@jreback
Copy link
Contributor

jreback commented Nov 26, 2020

thanks @topper-123 nice

@topper-123 topper-123 deleted the clean_ix_indexing.rst branch November 26, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants