Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: mark all plotting tests as slow #38079

Merged
merged 2 commits into from
Nov 28, 2020

Conversation

ivanovmg
Copy link
Member

Marked all plotting tests as slow globally at the top of each module.

@ivanovmg
Copy link
Member Author

One test fails in travis.

    def test_area_lim(self):
        df = DataFrame(np.random.rand(6, 4), columns=["x", "y", "z", "four"])

        neg_df = -df

        for stacked in [True, False]:
            ax = _check_plot_works(df.plot.area, stacked=stacked)
            xmin, xmax = ax.get_xlim()
            ymin, ymax = ax.get_ylim()
            lines = ax.get_lines()
            assert xmin <= lines[0].get_data()[0][0]
            assert xmax >= lines[0].get_data()[0][-1]
>           assert ymin == 0
E           assert -0.11510497676407896 == 0

My changes presumably did not affect it.

@ivanovmg
Copy link
Member Author

Locally this test passes, the same matplotlib version as in travis build, 3.3.2.

@jreback
Copy link
Contributor

jreback commented Nov 26, 2020

I am not sure this had an effect, i think these are actually already skipped, maybe with some exceptions). However the builds are still extremely slow (30+min for tests). let me make an issue about this.

@jreback jreback added the Visualization plotting label Nov 26, 2020
@jreback jreback added this to the 1.2 milestone Nov 26, 2020
@jreback
Copy link
Contributor

jreback commented Nov 26, 2020

xref #38091

@jreback
Copy link
Contributor

jreback commented Nov 26, 2020

can you merge master and let's see this run again.

@jreback jreback removed this from the 1.2 milestone Nov 26, 2020
@jreback jreback added this to the 1.2 milestone Nov 28, 2020
@jreback jreback added the Testing pandas testing functions or related to the test suite label Nov 28, 2020
@jreback jreback merged commit da5f914 into pandas-dev:master Nov 28, 2020
@jreback
Copy link
Contributor

jreback commented Nov 28, 2020

thanks @ivanovmg

can you update pandas/tests/plotting/common.py with some comments to indicate all test files are running as slow.

@ivanovmg ivanovmg deleted the test_plotting_slow branch November 30, 2020 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite Visualization plotting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants